Fix bug when sort repos on org home page login with non-admin #6741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
changed the title
techknowlogick
approved these changes
Apr 24, 2019
GiteaBot
added
the
lgtm/need 1
lunny
force-pushed
the
lunny/fix_org_repo_sort
branch
from
4bc8c4b
to
a6daf03
Compare
mrsdizzie
suggested changes
Apr 24, 2019
integrations/org_test.go
Outdated
|
|
||
| var ( | ||
| users = []string{"user1", "user2"} | ||
| kases = map[string][]string{ |
There was a problem hiding this comment.
Suggested change
| kases = map[string][]string{ | |
| cases = map[string][]string{ |
integrations/org_test.go
Outdated
| for _, user := range users { | ||
| t.Run(user, func(t *testing.T) { | ||
| session := loginUser(t, user) | ||
| for sortBy, repos := range kases { |
There was a problem hiding this comment.
Suggested change
| for sortBy, repos := range kases { | |
| for sortBy, repos := range cases { |
|
@mrsdizzie done. |
mrsdizzie
approved these changes
Apr 24, 2019
GiteaBot
added
lgtm/done
Codecov Report
@@ Coverage Diff @@
## master #6741 +/- ##
==========================================
+ Coverage 40.82% 40.98% +0.16%
==========================================
Files 421 421
Lines 57910 57915 +5
==========================================
+ Hits 23640 23738 +98
+ Misses 31131 31018 -113
- Partials 3139 3159 +20
Continue to review full report at Codecov.
|
lunny
added a commit
to lunny/gitea
that referenced
this pull request
Apr 25, 2019
techknowlogick
pushed a commit
that referenced
this pull request
Apr 25, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will fix #6511 with integration tests